Extensions: implement drop-down menus #700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 6, 2017 23:33
Also, add `ANGLE` argument type (like `NUMBER` but adds an angle picker)
ericrosenbaum
approved these changes
Oct 9, 2017
rschamp
approved these changes
Oct 11, 2017
src/engine/runtime.js
Outdated
| const menuId = this._makeExtensionMenuId(menuName, categoryInfo.id); | ||
|
|
||
| /** @TODO: support dynamic menus when 'menuItems' is a method name string (see extension spec) */ | ||
| const options = menuItems.map(item => { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| colour: categoryInfo.color1, | ||
| colourSecondary: categoryInfo.color2, | ||
| colourTertiary: categoryInfo.color3, | ||
| outputShape: ScratchBlocksConstants.OUTPUT_SHAPE_ROUND, |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Dynamic menus are not yet supported for extension menus, though they are part of the extension spec. This change provides more thorough feedback if an extension tries to register an unsupported dynamic menu.
stefania11
pushed a commit
to mitmedialab/cognimates-vm
that referenced
this pull request
Mar 31, 2018
Changed existing string ids to use the convention `<repo>.<component>.<identifier>`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #689
Proposed Changes
This change implements basic drop-down menu support for extension blocks. Dynamic menus -- ones which collect menu items fresh each time the menu opens -- are not yet supported.
Since I was in the area, I also fixed Boolean inputs and added angle picker support.
Reason for Changes
This is another step toward implementing the whole extension spec.