Skip to content

Tab-Bar Badge Preferences #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

seantan22
Copy link
Owner

@seantan22 seantan22 commented Jan 13, 2021

Fixes eclipse-theia#8709

What it does

  • Allows user to enable/disable tab-bar count badges for Explorer, SCM, Debug and Problems views via Preferences.
  • Creates new type for SCM view mode and refactors accordingly.

How to test

  1. Go to Preferences and search 'Count Badge'.
  2. Disable count badges for preferred views.
  3. Observe that badges do not appear in the selected views when
    changes are made to a file(s).

Review checklist

Reminder for reviewers

Signed-off-by: seantan22 [email protected]

@seantan22 seantan22 force-pushed the preference-countbadge branch 3 times, most recently from 41b40f5 to a5315c9 Compare January 13, 2021 15:26
@seantan22 seantan22 changed the title Tab-Bar Count Badge Preferences Tab-Bar Badge Preferences Jan 13, 2021
@seantan22 seantan22 force-pushed the preference-countbadge branch 2 times, most recently from 234facd to 0dcde88 Compare January 13, 2021 16:00
@seantan22 seantan22 force-pushed the preference-countbadge branch 3 times, most recently from c478c9d to 033c718 Compare January 13, 2021 18:50
Copy link
Collaborator

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments regarding the description of debug and scm badges.
Once addressed please feel free to upstream the changes 👍

@seantan22 seantan22 force-pushed the preference-countbadge branch 8 times, most recently from 41880b8 to 48eb45a Compare January 20, 2021 15:52
seantan22 added 2 commits April 5, 2021 16:54
Fixes eclipse-theia#8709

What It Does

- Allows user to enable/disable tab-bar count badges for Explorer, SCM, Debug, and Problems views via Preferences.

How to Test

1. Go to Preferences and search 'Count Badge'.
2. Disable count badges for preferred views.
3. Observe that badges do not appear in the views when
changes are made to a file(s).

Signed-off-by: seantan22 <[email protected]>
What It Does

Creates new type for SCM view mode and refactors accordingly.

Signed-off-by: seantan22 <[email protected]>
@seantan22 seantan22 force-pushed the preference-countbadge branch from 48eb45a to 3963d1e Compare April 5, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a Theia user I want to disable tab-bar badges via a preference
2 participants