Repository navigation
Handle LCD backlight calls without an applet proxy - #2537
Open
levischoonover wants to merge 1 commit into
Open
levischoonover wants to merge 1 commit into
levischoonover wants to merge 1 commit into
Conversation
github-actions
Bot
added
host
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Fixes #2224. Credit to mee-nora for the diagnosis and locally tested fix.
Leaving Smash’s Vault > Sounds crashes in
nn::oe::SwitchLcdBacklightOn()atsdk+0x32daa0: the SDK dereferences the null result ofam::GetCommonStateGetter(), whose service object the host does not create.Handle
SwitchLcdBacklightOnandSwitchLcdBacklightOffin the host, leaving the host display on. This applies generally, without a game-specific patch. The Switch’s screen-off music behavior is not emulated.Checked
t_oesuite passed all 53 checks;python3 -m unittest dm.tools.tests.test_docspassed all six tests01006A800016E000, version 13.0.5. The original host crashed when leaving Sounds. With the rebuilt host installed, the crash no longer occured. The log confirmed both additional hooks bound and the application exited with status 0.Docs
Added documentation in docs/reference/services.md and dm/games/01006A800016E000/README.md.
python3 dm/tools/docs_symptoms.pywas run (the symptom index)