Update tables.md #7652
Open
Update tables.md #7652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/unify/profiles-sync/tables.md
Outdated
| Raw tables contain complete historical data when using historical backfill. | ||
| Raw tables contain complete historical data when using historical backfill. | ||
|
|
||
| Note: `Timestamp` column will be empty for backfilled data. This is because we reverse engineer historical profile changes from the current state of the profile, and do not refer to the actual change history. |
There was a problem hiding this comment.
So we do not want to set to the current timestamp also? Also what is this timestamp? What does it refer to?
There was a problem hiding this comment.
timestamp refers to the instant at which the event was ingested into Segment. For backfill, we don't refer to individual events, but to the final profile state. So we don't have access to the original event timestamps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adding note on
Timestampcolumn being null in Profiles tables in case of backfill. This is expected behaviour and happens because we infer historical profile changes from the current state of the profile.Verified that
Timestampis null by running backfill in Staging.More context: Slack thread.
CSE requested change in documentation here: JIRA.
Merge timing
ASAP once approved.
Related issues (optional)
JIRA ticket: link.