Skip to content

add support for dynamic template data#262

Closed
nickhudkins wants to merge 1 commit intosendgrid:masterfrom
nickhudkins:feat/dynamic-template-data
Closed

add support for dynamic template data#262
nickhudkins wants to merge 1 commit intosendgrid:masterfrom
nickhudkins:feat/dynamic-template-data

Conversation

@nickhudkins
Copy link
Copy Markdown

Resolves #260

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Adds support for Dynamic Template Data via the Mail Helper

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Aug 9, 2018
@SendGridDX
Copy link
Copy Markdown

SendGridDX commented Aug 9, 2018

CLA assistant check
All committers have signed the CLA.

@nickhudkins nickhudkins force-pushed the feat/dynamic-template-data branch 2 times, most recently from a988808 to a6e02f0 Compare August 9, 2018 14:04
@nickhudkins nickhudkins force-pushed the feat/dynamic-template-data branch from a6e02f0 to 7f7135e Compare August 9, 2018 15:14
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 9, 2018

Codecov Report

Merging #262 into master will increase coverage by 0.85%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   70.75%   71.61%   +0.85%     
==========================================
  Files           3        3              
  Lines         448      451       +3     
==========================================
+ Hits          317      323       +6     
+ Misses        127      123       -4     
- Partials        4        5       +1
Impacted Files Coverage Δ
helpers/mail/mail_v3.go 99.24% <100%> (+1.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2921ca5...7f7135e. Read the comment docs.

@thinkingserious
Copy link
Copy Markdown
Contributor

Solved with: #263

We still appreciate your efforts and would love to send you some swag, please fill out this form so we can do that.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Dynamic Template Support

3 participants