Skip to content

fix broken link#292

Merged
thinkingserious merged 1 commit intosendgrid:masterfrom
pangaunn:fix-broken-link
Oct 23, 2018
Merged

fix broken link#292
thinkingserious merged 1 commit intosendgrid:masterfrom
pangaunn:fix-broken-link

Conversation

@pangaunn
Copy link
Copy Markdown
Contributor

@pangaunn pangaunn commented Oct 6, 2018

Fixes

Fixes #291

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Fix broken link.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 6, 2018
@SendGridDX
Copy link
Copy Markdown

SendGridDX commented Oct 6, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 6, 2018

Codecov Report

Merging #292 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #292   +/-   ##
=======================================
  Coverage   70.95%   70.95%           
=======================================
  Files           3        3           
  Lines         451      451           
=======================================
  Hits          320      320           
  Misses        127      127           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff34a53...4f4e898. Read the comment docs.

@agnesjang98
Copy link
Copy Markdown

LGTM

@agnesjang98 agnesjang98 added hacktoberfest difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Oct 11, 2018
@agnesjang98 agnesjang98 self-requested a review October 11, 2018 20:24
@thinkingserious thinkingserious merged commit 6d76920 into sendgrid:master Oct 23, 2018
@thinkingserious
Copy link
Copy Markdown
Contributor

Hello @pangaunn,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Copy Markdown
Contributor

Hello @pangaunn,

Thanks again for the PR!

We noticed that you have earned 4 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@pangaunn
Copy link
Copy Markdown
Contributor Author

Hi @thinkingserious ,
I'm actually have this pr unmerge could you possibly review it for me. Thanks.

@thinkingserious
Copy link
Copy Markdown
Contributor

Hello @pangaunn,

Thanks again for the PR!

You have earned 4 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken link in TROUBLESHOOTING.md

4 participants