Skip to content

Updated documenation for retrieving a list of all templates#294

Closed
Sarthakagarwal22 wants to merge 2 commits intosendgrid:masterfrom
Sarthakagarwal22:master
Closed

Updated documenation for retrieving a list of all templates#294
Sarthakagarwal22 wants to merge 2 commits intosendgrid:masterfrom
Sarthakagarwal22:master

Conversation

@Sarthakagarwal22
Copy link
Copy Markdown

@Sarthakagarwal22 Sarthakagarwal22 commented Oct 7, 2018

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Add generations URI parameter to USAGE.md to demonstrate how to use this API call to retrieve all templates (dynamic & legacy)

  • Add generations URI parameter to corresponding /example file to demonstrate how to use this API call to retrieve all templates (dynamic & legacy)

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 7, 2018
@SendGridDX
Copy link
Copy Markdown

SendGridDX commented Oct 7, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 7, 2018

Codecov Report

Merging #294 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #294   +/-   ##
=======================================
  Coverage   70.95%   70.95%           
=======================================
  Files           3        3           
  Lines         451      451           
=======================================
  Hits          320      320           
  Misses        127      127           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff34a53...d975fad. Read the comment docs.

@agnesjang98 agnesjang98 added hacktoberfest difficulty: easy fix is easy in difficulty difficulty: medium fix is medium in difficulty and removed difficulty: easy fix is easy in difficulty labels Oct 11, 2018
@Sarthakagarwal22
Copy link
Copy Markdown
Author

Hey team,
Could you please update on this issue, if this code solves the issue or not

@robertacosta
Copy link
Copy Markdown

While this would work, ultimately I think this solution uses the sendgrid/rest library queryParam as intended #295

@thinkingserious
Copy link
Copy Markdown
Contributor

Thanks for taking the time to contribute @Sarthakagarwal22!

Closed in favor of #295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants