Skip to content

feat: Add support for more bypass settings#425

Merged
eshanholtz merged 1 commit intosendgrid:mainfrom
yousifh:bypass-settings
Jan 29, 2021
Merged

feat: Add support for more bypass settings#425
eshanholtz merged 1 commit intosendgrid:mainfrom
yousifh:bypass-settings

Conversation

@yousifh
Copy link
Copy Markdown
Contributor

@yousifh yousifh commented Jan 28, 2021

Adds support for the other bypass filters settings as documented here https://sendgrid.com/docs/ui/sending-email/index-suppressions/#bypass-filters-and-v3-mail-send

The code changes just follow the same style as bypass_list_management as it's a simple field setting. I updated the tests to show the new fields being set properly. Note: I didn't modify the examples since these 3 new filters are mutually exclusive with bypass_list_management so modifying the existing examples will make the request object incorrect.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Add support for bypass_spam_management, bypass_bounce_management and
bypass_unsubscribe_management filters.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 28, 2021
Copy link
Copy Markdown
Contributor

@eshanholtz eshanholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eshanholtz eshanholtz merged commit a2c37d2 into sendgrid:main Jan 29, 2021
@yousifh yousifh deleted the bypass-settings branch January 29, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants