Skip to content

Optimize VisitIndex() case #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2024
Merged

Optimize VisitIndex() case #233

merged 1 commit into from
May 17, 2024

Conversation

SergeiPavlov
Copy link
Collaborator

@SergeiPavlov SergeiPavlov commented May 17, 2024 •
edited
Loading

Also:

  • Preallocate first 10 indexed constant expressions in ConstantExtractor to save GC
  • Use .ToArray() instead of .ToList() in ExtractColumnExpressions()

@SergeiPavlov SergeiPavlov requested a review from botinko May 17, 2024 02:12
@SergeiPavlov SergeiPavlov merged commit 88009dd into master-servicetitan May 17, 2024
2 checks passed
@SergeiPavlov SergeiPavlov deleted the VisitIndex branch May 17, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@botinko botinko botinko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeiPavlov @botinko