Surround the statement if switch-case block contains declarations.#1285
Merged
bors-servo merged 1 commit intoservo:masterfrom May 23, 2017
Merged
Surround the statement if switch-case block contains declarations.#1285bors-servo merged 1 commit intoservo:masterfrom
bors-servo merged 1 commit intoservo:masterfrom
Conversation
Contributor
|
It would be great to add this to the list of driver issues, even if this is not strictly coming from a driver. Or remind me to do it when I come back from vacation next week. |
kvark
reviewed
May 23, 2017
|
|
||
| switch (int(style)) { | ||
| case BORDER_STYLE_GROOVE: | ||
| { |
Member
There was a problem hiding this comment.
I don't see declarations in these switch cases. Are they also a problem?
Contributor
Author
There was a problem hiding this comment.
Forget to explain this case. See 1, ANGLE will translate ternary operator to type s; if(b) s = x; else s = y;. And type s is a declaration.
Member
There was a problem hiding this comment.
omg, that's somewhat obscure
thanks for clarification!
Member
|
I'll add it to the wiki. |
Contributor
|
📌 Commit 2f850a0 has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
May 23, 2017
Surround the statement if switch-case block contains declarations. This fix #1206 . <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1285) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix #1206 .
This change is