Skip to content

Work around OSX/Intel shader bug with integer comparison#2864

Merged
bors-servo merged 1 commit intoservo:masterfrom
kvark:osx-intel-comparison
Jul 4, 2018
Merged

Work around OSX/Intel shader bug with integer comparison#2864
bors-servo merged 1 commit intoservo:masterfrom
kvark:osx-intel-comparison

Conversation

@kvark
Copy link
Copy Markdown
Member

@kvark kvark commented Jul 3, 2018

Fixes #2862
Fixes #2754

Oh OSX GL drivers, so rough, such cruel, no remorse.
r? anyone


This change is Reviewable

@pcwalton
Copy link
Copy Markdown
Contributor

pcwalton commented Jul 3, 2018

Needs a comment explaining what's going on and linking to the issues.

@kvark
Copy link
Copy Markdown
Member Author

kvark commented Jul 3, 2018

@Darkspirit
Copy link
Copy Markdown

This will also fix bug 1423087, right?

@kvark
Copy link
Copy Markdown
Member Author

kvark commented Jul 4, 2018

@Darkspirit yes, sounds like it:

x86_64
Mac OS X

@pcwalton r?

@nical
Copy link
Copy Markdown
Contributor

nical commented Jul 4, 2018

@bors-servo r+

@bors-servo
Copy link
Copy Markdown
Contributor

📌 Commit e81c498 has been approved by nical

@bors-servo
Copy link
Copy Markdown
Contributor

⌛ Testing commit e81c498 with merge 686eca6...

bors-servo pushed a commit that referenced this pull request Jul 4, 2018
Work around OSX/Intel shader bug with integer comparison

Fixes #2862
Fixes #2754

Oh OSX GL drivers, so rough, such cruel, no remorse.
r? anyone

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2864)
<!-- Reviewable:end -->
@bors-servo
Copy link
Copy Markdown
Contributor

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: nical
Pushing 686eca6 to master...

@bors-servo bors-servo merged commit e81c498 into servo:master Jul 4, 2018
@kvark kvark deleted the osx-intel-comparison branch July 4, 2018 19:10
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 2, 2021
…. r=mstange

This removes the workaround from servo/webrender#2864

The root cause of that has been identified as bug 1690027.

Differential Revision: https://phabricator.services.mozilla.com/D103797
moz-gfx pushed a commit to moz-gfx/webrender that referenced this pull request Feb 2, 2021
…. r=mstange

This removes the workaround from servo#2864

The root cause of that has been identified as bug 1690027.

Differential Revision: https://phabricator.services.mozilla.com/D103797

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/18835f3f39365c75abed1f7db9b8dcdcfaf38f1b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Feb 3, 2021
…. r=mstange

This removes the workaround from servo/webrender#2864

The root cause of that has been identified as bug 1690027.

Differential Revision: https://phabricator.services.mozilla.com/D103797

UltraBlame original commit: 18835f3f39365c75abed1f7db9b8dcdcfaf38f1b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Feb 3, 2021
…. r=mstange

This removes the workaround from servo/webrender#2864

The root cause of that has been identified as bug 1690027.

Differential Revision: https://phabricator.services.mozilla.com/D103797

UltraBlame original commit: 18835f3f39365c75abed1f7db9b8dcdcfaf38f1b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Feb 3, 2021
…. r=mstange

This removes the workaround from servo/webrender#2864

The root cause of that has been identified as bug 1690027.

Differential Revision: https://phabricator.services.mozilla.com/D103797

UltraBlame original commit: 18835f3f39365c75abed1f7db9b8dcdcfaf38f1b
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Feb 4, 2021
…. r=mstange

This removes the workaround from servo/webrender#2864

The root cause of that has been identified as bug 1690027.

Differential Revision: https://phabricator.services.mozilla.com/D103797
bhearsum pushed a commit to mozilla-releng/staging-firefox that referenced this pull request May 1, 2025
…. r=mstange

This removes the workaround from servo/webrender#2864

The root cause of that has been identified as bug 1690027.

Differential Revision: https://phabricator.services.mozilla.com/D103797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants