Better handle incomplete display lists during hit testing #4867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
force-pushed
the
incomplete-display-lists
branch
from
36669fe to
6571344
Compare
mukilan
approved these changes
May 1, 2025
Our custom hit testing code tries to find the root node of a pipeline. There can be references to non-existant pipelines if hit testing is performed at a time when not all display lists have arrived to WebRender yet. This changes handles that situation more gracefully instead of panicking.
mrobinson
force-pushed
the
incomplete-display-lists
branch
from
6571344 to
09dc9c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our custom hit testing code tries to find the root node of a pipeline. There can be references to non-existant pipelines if hit testing is performed at a time when not all display lists have arrived to WebRender yet. This changes handles that situation more gracefully instead of panicking.