Skip to content

Add PG JSON to Arrow transport rules #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 24, 2022

Conversation

gruuya
Copy link
Contributor

@gruuya gruuya commented Nov 21, 2022

There are a couple of (related) changes in this PR, all of which underpin the remote table functionality that we've recently built on Seafowl:

  • the JSON transport mappings just align the existing implementation in Arrow 2 with the missing one in Arrow.
  • likewise, the missing arrow association rules for DateTime<Utc> and Option<DateTime<Utc>> (PG Timestampz type) are added. Unlike in Arrow 2, we don't have a builder that will collect the Timestamp values with a UTC zone set, so we have to set it to None instead.
  • finally bump sqlite related libs, and fix resulting conflicts (columns and column_names function changes).

Basically, we use these changes on our connector-x fork, but given that they are pretty general it may be useful to contribute them upstream.

@wangxiaoying
Copy link
Contributor

Hi @gruuya , thanks for the PR, it looks great!

@wangxiaoying wangxiaoying merged commit feacc61 into sfu-db:main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants