Feat/add support for _text #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wangxiaoying Would you mind taking a look at this when you have a chance? |
|
Hi @Jordan-M-Young , sorry for the late reply. Thanks for the PR! It looks good to me, I will try to make an alpha release for it by this weeken. |
|
@wangxiaoying No worries! Thanks for merging this! |
|
Really appreciate you having done this @Jordan-M-Young. Works perfectly. |
|
Happy to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to extend support for the _text type as requested by a user within the issue: #480. This issue centers around connectorx panicking when interacting with tables containing a text[] type.
To solve this, I added: