Skip to content

Arrow2 and Polars- versions are terribly outdated - updated #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 27, 2023

Conversation

AnatolyBuga
Copy link
Contributor

@AnatolyBuga AnatolyBuga commented Aug 1, 2023

Updated varsions:

arrow2 = {version = "0.17.4", default-features = false, optional = true}
polars = {version = "0.32.1", optional = true, features=["dtype-u8", "dtype-u16"]}

@AnatolyBuga
Copy link
Contributor Author

AnatolyBuga commented Aug 16, 2023

@wangxiaoying , 1) test_arrow fails to compile due to out of memory. I think this could be fixed if tests were ran with --release flag. Can you try that locally?
2) Python fails due to bytes version. I will update cargo.toml

@wangxiaoying
Copy link
Contributor

wangxiaoying commented Aug 18, 2023

Hi @AnatolyBuga , thanks for the PR!

Looks like the rust test has some linking error. And seems like python test still has some arrow API related issues.

I have a branch which has bumped arrow version. But it has some other features that need time to fully merge (I'm planning to do this in September). Not sure whether it can be helpful for this PR.

@AnatolyBuga
Copy link
Contributor Author

@wangxiaoying , the branch you linked to has same old versions (arrow2 0.10, polars 0.20 etc)

I have updated connectorx-python/src scripts.

For me locally both connector-x and connectorx-python build fine (ie cargo b --all-features works).
Rust's linking error is very strange. I could only suggest adding --release to cargo test

@wangxiaoying
Copy link
Contributor

wangxiaoying commented Aug 21, 2023

@wangxiaoying , the branch you linked to has same old versions (arrow2 0.10, polars 0.20 etc)

Oh, right this is a newer version arrow2 not arrow.

For me locally both connector-x and connectorx-python build fine (ie cargo b --all-features works). Rust's linking error is very strange. I could only suggest adding --release to cargo test

I'm not sure using --release is a way to fix the issue, and we need to be able to run tests under debug mode.
Here is the script of the github workflow of our ci, including environment and dependency setup. Maybe it can be useful for you to test locally.

@wangxiaoying
Copy link
Contributor

Hi @AnatolyBuga , again thanks for the PR.

I checked the code and fixed the python error here.

As for the rust error, it seems like it is not related to this PR since we saw all other PRs all have this same error: #530

@wangxiaoying wangxiaoying merged commit ed9aa7a into sfu-db:main Aug 27, 2023
@AnatolyBuga
Copy link
Contributor Author

thank you very much @wangxiaoying for your help and for this great library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants