-
Notifications
You must be signed in to change notification settings - Fork 181
Update int/float size for PostgreSQL, add PostgreSQL tests and fix various bugs #743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @EricFecteau , thanks for the PR! It looks good. I only left a few comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this pull request is to:
int
andfloat
smaller (e.g. don't convert alli16
toi64
) -- this adds the framework for Int dtypes are unnecessarily big #688 for Postgres -> Polars, but not mysql -> Polars)Comments
Bugs
While writing tests, I encountered a few bugs and solved them:
Null
within an array would fail in PostgreSQL! I implemented this to work in Rust. I did not implement this for Pandas (but kept it as-is, with anunimplemented!
UTC
time being used in the crate was not recognized by Arrow, due to the lack of thechrono-tz
feature. Fixed by moving to+00:00
instead.