-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Support async in DeepEP #4610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Support async in DeepEP #4610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
For future reference, I did a simple benchmark on one 8xH200 machine for this PR. Here is the command
Results:
|
ch-wan
reviewed
Mar 23, 2025
ch-wan
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When doing #4068, DeepEP needs to be async. This PR enables that in a minimal way.
(This is a separate PR because #4068 may not be done in a day, and I hope less merge conflicts happen, so extract this part first)
Related: #4232 (Initial DeepEP support)
When viewing diff, please subtract from change in #4608
In order to demonstrate the PR works, I set
async_finish=True
temporarily. In real world, maybe async will be true only when doing two-batch-overlap. The flag will be handled in #4068. (I can also make it false in this PR if needed)Modifications
Checklist