Skip to content

Log the timestamps of each prefill/decode iteration #6094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 7, 2025

Conversation

yuhsuan-t
Copy link
Contributor

Motivation

Logging the timestamps along with other stats helps with debugging performance issues

Modifications

Add timestamps to the prefill/decode logging functions.

Checklist

@yuhsuan-t yuhsuan-t force-pushed the yuhsuan-t/timestamp_logging branch 2 times, most recently from aa5d598 to 4957840 Compare May 14, 2025 16:57
@xiezhq-hermann
Copy link
Collaborator

@hebiao064 can you take a final pass and we finalize the merge of this PR?

@Fridge003 Fridge003 added the ready-to-merge The PR is ready to merge after the CI is green. label Jun 2, 2025
@Fridge003
Copy link
Collaborator

Hi @yuhsuan-t, please fix the conflict

yuhsuan-t added 2 commits June 6, 2025 15:35
Logging the timestamps along with other stats helps with debugging performance issues
For better readability and parsability.
@yuhsuan-t yuhsuan-t force-pushed the yuhsuan-t/timestamp_logging branch from 4957840 to b67c648 Compare June 6, 2025 22:36
@yuhsuan-t
Copy link
Contributor Author

@Fridge003 Fixed the conflict. Thanks!

@xiezhq-hermann
Copy link
Collaborator

@yuhsuan-t sorry for the delay, I approved the change and could you help doing a rebase one more time and we can get it merged. Thanks!

@Fridge003 Fridge003 enabled auto-merge (squash) July 7, 2025 01:47
@Fridge003 Fridge003 merged commit 8d4a01c into sgl-project:main Jul 7, 2025
6 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge The PR is ready to merge after the CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants