-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Log the timestamps of each prefill/decode iteration #6094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Fridge003
merged 9 commits into
sgl-project:main
from
yuhsuan-t:yuhsuan-t/timestamp_logging
Jul 7, 2025
Merged
Log the timestamps of each prefill/decode iteration #6094
Fridge003
merged 9 commits into
sgl-project:main
from
yuhsuan-t:yuhsuan-t/timestamp_logging
Jul 7, 2025
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebiao064
reviewed
May 9, 2025
aa5d598
to
4957840
Compare
@hebiao064 can you take a final pass and we finalize the merge of this PR? |
hebiao064
approved these changes
May 31, 2025
Hi @yuhsuan-t, please fix the conflict |
Logging the timestamps along with other stats helps with debugging performance issues
For better readability and parsability.
4957840
to
b67c648
Compare
@Fridge003 Fixed the conflict. Thanks! |
xiezhq-hermann
approved these changes
Jun 12, 2025
@yuhsuan-t sorry for the delay, I approved the change and could you help doing a rebase one more time and we can get it merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Logging the timestamps along with other stats helps with debugging performance issues
Modifications
Add timestamps to the prefill/decode logging functions.
Checklist