Skip to content

Support qwen3 deepep #6120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 22, 2025
Merged

Support qwen3 deepep #6120

merged 11 commits into from
May 22, 2025

Conversation

sleepcoo
Copy link
Collaborator

@sleepcoo sleepcoo commented May 8, 2025

Motivation

Support qwen3's deepep. For now, we've simply copied the deepep code from DS, and the accuracy test has passed.

TODO

  • test bf16 compatibility

Test Command

 python3 -m sglang.launch_server --model-path /workdir/huggingface.co/Qwen/Qwen3-235B-A22B-FP8/ --tp 4 --trust-remote --enable-torch-compile --torch-compile-max-bs 8 --host 0.0.0.0 --port 8418 --reasoning-parser qwen3 --tool-call-parser qwen25 --enable-deepep-moe --deepep-mode normal 

gsm8k Accuracy: 0.970

@sleepcoo sleepcoo requested review from ch-wan and xutizhou May 8, 2025 09:22
@ch-wan ch-wan self-assigned this May 9, 2025
@yizhang2077
Copy link
Collaborator

Do we need raise error for bf16 when enable deepep?

@sleepcoo
Copy link
Collaborator Author

sleepcoo commented May 9, 2025

Do we need raise error for bf16 when enable deepep?

I'm not sure, it's necessary? @zhyncs @ch-wan

@ch-wan
Copy link
Collaborator

ch-wan commented May 9, 2025

Do we need raise error for bf16 when enable deepep?

I'm not sure, it's necessary? @zhyncs @ch-wan

@sleepcoo How about raising NotImplementedError if it is not urgent?

@yizhang2077 yizhang2077 force-pushed the support-qwen3-deepep branch from 91ac718 to ffcf97b Compare May 17, 2025 03:31
yizhang2077
yizhang2077 previously approved these changes May 17, 2025
@yizhang2077 yizhang2077 dismissed their stale review May 17, 2025 04:03

some bus

@MtFitzRoy
Copy link

When can we support qwen3 bf16 with deepep?

@yizhang2077
Copy link
Collaborator

When can we support qwen3 bf16 with deepep?

I think deepep currently do not support bf16 dispatch?

@MtFitzRoy
Copy link

@yizhang2077
Copy link
Collaborator

yizhang2077 commented May 22, 2025

@yizhang2077 Seems DeepEP already support bf16 dispatch https://github.com/deepseek-ai/DeepEP?tab=readme-ov-file#roadmap

I think normal mode is unmentioned

@yizhang2077 yizhang2077 mentioned this pull request May 22, 2025
6 tasks
@zhyncs zhyncs merged commit fc0e3b9 into sgl-project:main May 22, 2025
16 of 40 checks passed
@sleepcoo sleepcoo deleted the support-qwen3-deepep branch May 22, 2025 18:19
@MtFitzRoy
Copy link

@yizhang2077 For normal mode dispatch, I think sglang code already support bf16.

Layssy pushed a commit to Layssy/sglang-iaas that referenced this pull request Jun 9, 2025
xwu-intel pushed a commit to xwu-intel/sglang that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants