Skip to content

[dd] Remove dead code #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[dd] Remove dead code #1271

wants to merge 8 commits into from

Conversation

alejandro-colomar
Copy link
Collaborator

@alejandro-colomar alejandro-colomar commented Jun 9, 2025 •
edited
Loading

These are cherry-picks from #1220

Revisions:

v1b
  • Rebase
$ git rd 
1:  39d17867 = 1:  6cedeac5 src/useradd.c: Remove unused variable
2:  45093ec7 = 2:  ecfaab1c src/gpasswd.c: Remove unused parameter $1 of check_perms()
3:  1f631d20 = 3:  94ae417b lib/, src/: Remove unused parameter $2 of audit_logger()
4:  6622b830 = 4:  b1147d69 lib/copydir.c: Remove unused parameter $3 of copy_symlink()
5:  a4d5227b = 5:  d8cc2df0 lib/copydir.c: Remove unused parameter $2 of copy_hardlink()
6:  13349cc4 = 6:  f74c3c01 lib/: Remove unused parameter $3 of password_check() and propagate
7:  b0f68a65 = 7:  aa0b2ec1 lib/obscure.c: Remove unused parameter $1 of palindrome()
8:  d001ed6f = 8:  a1c13db0 lib/, src/: Remove unused parameter $3 of passwd_check()

@alejandro-colomar alejandro-colomar mentioned this pull request Jun 9, 2025
Draft
@alejandro-colomar
src/useradd.c: Remove unused variable
6cedeac 
Fixes: d91b22c (2024-07-08; "lib/, src/: Use stpsep() instead of its pattern")
Signed-off-by: Alejandro Colomar <[email protected]>
@alejandro-colomar
src/gpasswd.c: Remove unused parameter $1 of check_perms()
ecfaab1 
Fixes: 53e1eb4 (2024-07-01; "src/: Remove dead code")
Signed-off-by: Alejandro Colomar <[email protected]>
@alejandro-colomar
lib/, src/: Remove unused parameter $2 of audit_logger()
94ae417 
Signed-off-by: Alejandro Colomar <[email protected]>
@alejandro-colomar
lib/copydir.c: Remove unused parameter $3 of copy_symlink()
b1147d6 
Signed-off-by: Alejandro Colomar <[email protected]>
@alejandro-colomar
lib/copydir.c: Remove unused parameter $2 of copy_hardlink()
d8cc2df 
Signed-off-by: Alejandro Colomar <[email protected]>
@alejandro-colomar
lib/: Remove unused parameter $3 of password_check() and propagate
f74c3c0 
Propagate the removal of dead code to its callers, which were only
passing the parameter to this function.

Signed-off-by: Alejandro Colomar <[email protected]>
@alejandro-colomar
lib/obscure.c: Remove unused parameter $1 of palindrome()
aa0b2ec 
Signed-off-by: Alejandro Colomar <[email protected]>
@alejandro-colomar
lib/, src/: Remove unused parameter $3 of passwd_check()
a1c13db 
Signed-off-by: Alejandro Colomar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikerexxe ikerexxe Awaiting requested review from ikerexxe

@hallyn hallyn Awaiting requested review from hallyn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alejandro-colomar