"TypeError: Property 'handleEvent' is not callable." in Firefox

[hheexx]

In firefox on load and on scroll I receive this error in console:

TypeError: Property 'handleEvent' is not callable.

I have debugged a little and found the reason.
util/dom.js
addStepEventListeners() lines 82, 83
https://github.com/shipshapecode/shepherd/blob/master/src/js/utils/dom.js#L82

this._onScreenChange is null. You can't register null handler.

[RobbieTheWagner]

@hheexx thanks for the bug report! this._onScreenChange is set here

shepherd/src/js/modal.js

Line 100 in 35b0647

this._onScreenChange = debounce(

We must be calling things in the wrong order somewhere or something. Do you have time to work on a PR with a fix perhaps?

[hheexx]

I will try a little bit now. But if it's concurrency bug it may be much easier to fix by somebody who knows the code....

[RobbieTheWagner]

@hheexx can you share with me your initialization/config for Shepherd?

It appears it might be an issue for a case where you are using the modal functionality, but one of the steps has no attachTo.

[hheexx]

Yes. My first step has no attachTo. It's ment to be in center of the page.

[RobbieTheWagner]

@hheexx I just opened #396 which may or may not fix the problem. Could you try it out?

[hheexx]

@rwwagner90 Fixes problem for me. No errors. No regressions noticed.

[hheexx]

@rwwagner90 btw. I have scrollTo problems. It misses component compleatly and selects top of page?
Do you consider ScrollTo implementation good or it has lot of problems?
Should we try to debug it or should I try to use scrollToHandler?

[RobbieTheWagner]

@hheexx scrollTo should scroll correctly. It works on the demo page. Do you have a reproduction of an issue?

[hheexx]

@rwwagner90 yes I do.

https://dev.goglasi.com/posao/prodaja-i-marketing/search?categoryId=204
Open on mobile.
Tour will show up.
First step is not tied to an element. Second and third are ok.
Forth step needs to scroll a little bit and you can see it scrols wrong.
https://i.gyazo.com/01abe39dfca7bbd61b206ca0322753fd.png

Step code:

tour.addStep('step5', {
			title: 'Uputstvo',
			text: 'Isto važi i za promene cene određenog oglasa (klik i saznaćete kada cena bude snižena). ',
			attachTo: { element: document.querySelectorAll('.follow-price-btn')[0], on: isMobile ? 'top' : 'left' },
			scrollTo: true,
			buttons: [
				{ text: 'Isključi', action: tour.cancel },
				{ text: 'Dalje', action: tour.next }
			]
		});

[RobbieTheWagner]

@hheexx this seems like a separate issue or did it just start happening on the branch that fixes the firefox bug?

[hheexx]

@rwwagner90 seperate issue. I just wanted you to confirm it first, I can create seperate bug if needed.

[RobbieTheWagner]

@hheexx that issue seems to be one with your app, not with Shepherd. The thing scrolling into view is hidden by the navbar. It does correctly scroll it into the top of the viewport.

[hheexx]

@rwwagner90 step is positioned 'top'.
My expectation is that element should be positioned in middle of bottom 1/3 of the screen with step baloon above it. I understand header is hiding it but element should not be sticked to the top of the screen.