Feature Request: I18n cancel link

[knoobie]

Currently the cancel link has a hardcoded english message and a × that is not changeable.

Proposal:

instead of:

  showCancelLink: true

how about:

  cancel: {
    enable: true,
    caption: '×', // can be html
    aria-label: 'aria-label is only added to the component if config is present and != null',
  }

[RobbieTheWagner]

@knoobie I am open to making things configurable. Shouldn't everything be i18n capable then? Not sure what else we might need to tweak.

[knoobie]

@rwwagner90 I'm a huge fan of i18n everywhere. Let me check later if I can find more. That was the first thing I found.

[knoobie]

Update: I think all other things are i18n already :)

[RobbieTheWagner]

@knoobie do you think we need to be able to change the "x"? I feel like we can keep that, and we could then add cancelLinkLabel as a new option or something.

[knoobie]

Was wondering the same.. but for example - a company uses FontAwesome as icon base - they would probably wanna use <i class="far fa-times-circle"></i> as icon.

[RobbieTheWagner]

Fair enough. I just don't want to have a breaking API change for this small improvement, so perhaps we should add cancelLinkLabel and cancelLinkHTML or something.

[knoobie]

Fair enough!

[RobbieTheWagner]

@knoobie I just merged a different breaking change, so we should be okay to do a breaking change here. Will get something up.