Remove shepherd-target-click-disabled class on step hide#1189
Merged
RobbieTheWagner merged 1 commit intoshipshapecode:masterfrom Oct 9, 2020
Merged
Conversation
RobbieTheWagner
approved these changes
Oct 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, this fixes an issue where the
shepherd-target-click-disabledclass is not removed from the highlight target after a step is hidden. Whileshepherd-activeandshepherd-targetclasses are correctly removed on stephide, theshepherd-target-click-disabledis not.shepherd-target-click-disabledis only removed when the tour completes.This problem prevents touring the same element twice, where in one step it's not clickable, and in the other it is. See the repro: https://codesandbox.io/s/practical-ives-9j6u9