Merged
Conversation
* add editorconfig for consistent coding styles * Set default severity for stylelint so that the build- and linting process does not fail * use relative paths * usage of inline maps for welcome page styles * using webpack alias to resolve popper.js * webpack config for all scss and js sources - usage of browser-sync to have live-reload - stylelint inside build - copy assets (popper.js) with CopyWebpackPlugin * adjust webpack build scripts - remove webpack-dev-server and use watch with browser-sync instead - install missing dependencies for webpack build * remove unwanted property to make build fail on lin violations * expand css output for welcome page styles * - revert index.html (need these paths for when we deploy to gh-pages) * insert final new line * enforce styles with eslint and stylelint, so we should not need this file
| } | ||
|
|
||
| /*# sourceMappingURL=welcome.css.map */ No newline at end of file | ||
| /*# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJzb3VyY2VzIjpbIi9Vc2Vycy9yd3dhZ25lci9zaGlwc2hhcGUvc2hlcGhlcmQvZG9jcy93ZWxjb21lL3Nhc3Mvd2VsY29tZS5zY3NzIiwiZG9jcy93ZWxjb21lL3Nhc3Mvd2VsY29tZS5zY3NzIl0sIm5hbWVzIjpbXSwibWFwcGluZ3MiOiJBQUlBOztFQUVFLGFBQVk7RUFDWixpQkFBZ0I7Q0FDakI7O0FBRUQ7RUFDRSwwQkFBa0M7RUFDbEMsNERBQStFO0VBQy9FLDBEQUF5RDtFQUN6RCxVQUFTO0NBQ1Y7O0FBRUQ7RUFDRSwwQkFoQm1CO0VBaUJuQixlQWpCbUI7RUFrQm5CLGdCQUFlO0VBQ2Ysc0JBQXFCO0VBQ3JCLGlCQUFnQjtFQUNoQixpQkFBZ0I7RUFDaEIsb0JBQW1CO0VBQ25CLG1CQUFrQjtFQUNsQixvQkFBbUI7RUFDbkIsc0JBQXFCO0VBQ3JCLDBCQUF5QjtFQUN6QixhQUFZO0NBV2I7O0FBdkJEO0VBZUksb0JBOUJpQjtFQStCakIsZUFBeUI7Q0FDMUI7O0FBRUQ7RUFuQkY7SUFvQkksZUFBYztJQUNkLG1CQUFrQjtHQUVyQjtDQ0ZBOztBRElEO0VBQ0UsYUFBWTtFQUNaLGVBQWM7RUFDZCxrQ0FBaUM7RUFDakMsWUFBVztDQUNaOztBQUVEO0VBQ0UsK0JBQXNCO1VBQXRCLHVCQUFzQjtFQUN0QixlQUFjO0VBQ2QsYUFBWTtFQUNaLGdCQUFlO0VBQ2YsWUFBVztDQXNEWjs7QUEzREQ7RUFRSSxtQkFBa0I7RUFDbEIsbUJBQWtCO0VBQ2xCLGFBQVk7Q0E0Q2I7O0FBMUNDO0VBWko7SUFhTSxhQUFZO0dBeUNmO0NDdENGOztBREFHO0VBaEJKO0lBaUJNLGFBQVk7R0FxQ2Y7Q0NoQ0Y7O0FEdEJEOzs7O0VBd0JNLGVBdkVlO0VBd0VmLG9CQUFtQjtFQUNuQixlQUFjO0VBQ2QsaUJBQWdCO0NBQ2pCOztBQTVCTDtFQStCTSxpQkFBZ0I7RUFDaEIsa0JBQWlCO0NBQ2xCOztBQWpDTDtFQW9DTSxrQkFBaUI7Q0FDbEI7O0FBckNMO0VBd0NNLGFBQVk7RUFDWixxQkFBb0I7RUFDcEIsaUNBQXdCO0VBQXhCLHlCQUF3QjtDQU16Qjs7QUFKQztFQUNFLFdBQVU7RUFDVixxQkFBb0I7Q0FDckI7O0FBL0NQO0VBbURNLFdBQVU7RUFDVixxQkFBb0I7Q0FDckI7O0FBckRMO0VBeURJLGtCQUFpQjtDQUNsQjs7QUFHSDtFQUVJLGVBL0dpQjtDQWdIbEI7O0FBSEg7RUFNSSxnQkFBZTtFQUNmLGFBQVk7Q0FTYjs7QUFoQkg7RUFVTSxpQkF4SG1CO0NBeUhwQjs7QUFYTDtFQWNNLG9CQUFtQjtDQUNwQjs7QUFJTDtFQUNFLHNDQUFxQztFQUNyQyxtQkFBa0I7Q0FDbkIiLCJmaWxlIjoiZG9jcy93ZWxjb21lL3Nhc3Mvd2VsY29tZS5zY3NzIiwic291cmNlc0NvbnRlbnQiOlsiJGNvbG9yLWluaGVyaXQ6IFwiaW5oZXJpdFwiO1xuJGNvbG9yLWdyZWVuOiAjM2I3NDRmO1xuJGNvbG9yLXdoaXRlOiAjZmZmZmZmO1xuXG5odG1sLFxuYm9keSB7XG4gIGhlaWdodDogMTAwJTtcbiAgb3ZlcmZsb3c6IGhpZGRlbjtcbn1cblxuYm9keSB7XG4gIGJhY2tncm91bmQtY29sb3I6IHJnYig5OCwgMTk2LCA5OCk7XG4gIGJhY2tncm91bmQtaW1hZ2U6IGxpbmVhci1ncmFkaWVudCgtNDVkZWcsIHJnYig5OCwgMTk2LCA5OCksIHJnYigxMTcsIDE5MCwgMTcwKSk7XG4gIGZvbnQtZmFtaWx5OiBcInByb3hpbWEtbm92YVwiLCBcIkhlbHZldGljYSBOZXVlXCIsIHNhbnMtc2VyaWY7XG4gIG1hcmdpbjogMDtcbn1cblxuLmJ1dHRvbiB7XG4gIGJvcmRlcjogMnB4IHNvbGlkICRjb2xvci13aGl0ZTtcbiAgY29sb3I6ICRjb2xvci13aGl0ZTtcbiAgY3Vyc29yOiBwb2ludGVyO1xuICBkaXNwbGF5OiBpbmxpbmUtYmxvY2s7XG4gIGZvbnQtc2l6ZTogMC44ZW07XG4gIGZvbnQtd2VpZ2h0OiA1MDA7XG4gIGxldHRlci1zcGFjaW5nOiAzcHg7XG4gIGxpbmUtaGVpZ2h0OiAxLjNlbTtcbiAgcGFkZGluZzogMWVtIDEuMjVlbTtcbiAgdGV4dC1kZWNvcmF0aW9uOiBub25lO1xuICB0ZXh0LXRyYW5zZm9ybTogdXBwZXJjYXNlO1xuICB3aWR0aDogMTQwcHg7XG5cbiAgJi5kYXJrIHtcbiAgICBiYWNrZ3JvdW5kOiAkY29sb3Itd2hpdGU7XG4gICAgY29sb3I6IHJnYigxMTcsIDE5MCwgMTcwKTtcbiAgfVxuXG4gIEBtZWRpYSAobWF4LXdpZHRoOiA1NjhweCkge1xuICAgIGRpc3BsYXk6IGJsb2NrO1xuICAgIG1hcmdpbjogMWVtIGF1dG8gMDtcbiAgfVxufVxuXG4uaGVyby1zY3JvbGwge1xuICBoZWlnaHQ6IDEwMCU7XG4gIG92ZXJmbG93OiBhdXRvO1xuICAtd2Via2l0LW92ZXJmbG93LXNjcm9sbGluZzogdG91Y2g7XG4gIHdpZHRoOiAxMDAlO1xufVxuXG4uaGVyby1vdXRlciB7XG4gIGJveC1zaXppbmc6IGJvcmRlci1ib3g7XG4gIGRpc3BsYXk6IHRhYmxlO1xuICBoZWlnaHQ6IDEwMCU7XG4gIHBhZGRpbmc6IDIwcHggMDtcbiAgd2lkdGg6IDEwMCU7XG5cbiAgLmhlcm8taW5uZXIge1xuICAgIG1hcmdpbjogMCBhdXRvIDFlbTtcbiAgICB0ZXh0LWFsaWduOiBjZW50ZXI7XG4gICAgd2lkdGg6IDU0MHB4O1xuXG4gICAgQG1lZGlhIChtYXgtd2lkdGg6IDYwMHB4KSB7XG4gICAgICB3aWR0aDogMzQwcHg7XG4gICAgfVxuXG4gICAgQG1lZGlhIChtYXgtd2lkdGg6IDM2MHB4KSB7XG4gICAgICB3aWR0aDogMjAwcHg7XG4gICAgfVxuXG4gICAgaDEsXG4gICAgaDIsXG4gICAgaDMsXG4gICAgcCB7XG4gICAgICBjb2xvcjogJGNvbG9yLXdoaXRlO1xuICAgICAgZm9udC13ZWlnaHQ6IG5vcm1hbDtcbiAgICAgIGxpbmUtaGVpZ2h0OiAxO1xuICAgICAgbWFyZ2luOiAwIDAgMjBweDtcbiAgICB9XG5cbiAgICBoMyB7XG4gICAgICBmb250LXNpemU6IDEuM2VtO1xuICAgICAgcGFkZGluZy10b3A6IDEzcHg7XG4gICAgfVxuXG4gICAgaDEge1xuICAgICAgcGFkZGluZy10b3A6IDEwcHg7XG4gICAgfVxuXG4gICAgPiAqIHtcbiAgICAgIG9wYWNpdHk6IDAuMztcbiAgICAgIHBvaW50ZXItZXZlbnRzOiBub25lO1xuICAgICAgdHJhbnNpdGlvbjogb3BhY2l0eSAwLjRzO1xuXG4gICAgICBib2R5Om5vdCguc2hlcGhlcmQtYWN0aXZlKSAmIHtcbiAgICAgICAgb3BhY2l0eTogMTtcbiAgICAgICAgcG9pbnRlci1ldmVudHM6IGF1dG87XG4gICAgICB9XG4gICAgfVxuXG4gICAgLnNoZXBoZXJkLXRhcmdldC5zaGVwaGVyZC1lbmFibGVkIHtcbiAgICAgIG9wYWNpdHk6IDE7XG4gICAgICBwb2ludGVyLWV2ZW50czogYXV0bztcbiAgICB9XG4gIH1cblxuICAuaGVyby1mb2xsb3d1cCB7XG4gICAgcGFkZGluZy10b3A6IDIwcHg7XG4gIH1cbn1cblxuLnNoZXBoZXJkLWVsZW1lbnQge1xuICAmLnNoZXBoZXJkLXRyYW5zcGFyZW50LXRleHQgLnNoZXBoZXJkLXRleHQge1xuICAgIGNvbG9yOiAkY29sb3ItZ3JlZW47XG4gIH1cblxuICAuc2hlcGhlcmQtY29udGVudCB7XG4gICAgbWF4LXdpZHRoOiAxMDAlO1xuICAgIHdpZHRoOiA0MDBweDtcblxuICAgIGEge1xuICAgICAgY29sb3I6ICRjb2xvci1pbmhlcml0O1xuICAgIH1cblxuICAgIGZvb3RlciAuc2hlcGhlcmQtYnV0dG9ucyBsaSAuc2hlcGhlcmQtYnV0dG9uLWV4YW1wbGUtcHJpbWFyeSB7XG4gICAgICBiYWNrZ3JvdW5kOiAjNTVhODkyO1xuICAgIH1cbiAgfVxufVxuXG5wcmUge1xuICBib3JkZXI6IDFweCBzb2xpZCByZ2JhKDAsIDAsIDAsIDAuMTUpO1xuICBsaW5lLWhlaWdodDogMS40ZW07XG59XG4iLCJodG1sLFxuYm9keSB7XG4gIGhlaWdodDogMTAwJTtcbiAgb3ZlcmZsb3c6IGhpZGRlbjtcbn1cblxuYm9keSB7XG4gIGJhY2tncm91bmQtY29sb3I6ICM2MmM0NjI7XG4gIGJhY2tncm91bmQtaW1hZ2U6IGxpbmVhci1ncmFkaWVudCgtNDVkZWcsICM2MmM0NjIsICM3NWJlYWEpO1xuICBmb250LWZhbWlseTogXCJwcm94aW1hLW5vdmFcIiwgXCJIZWx2ZXRpY2EgTmV1ZVwiLCBzYW5zLXNlcmlmO1xuICBtYXJnaW46IDA7XG59XG5cbi5idXR0b24ge1xuICBib3JkZXI6IDJweCBzb2xpZCAjZmZmZmZmO1xuICBjb2xvcjogI2ZmZmZmZjtcbiAgY3Vyc29yOiBwb2ludGVyO1xuICBkaXNwbGF5OiBpbmxpbmUtYmxvY2s7XG4gIGZvbnQtc2l6ZTogMC44ZW07XG4gIGZvbnQtd2VpZ2h0OiA1MDA7XG4gIGxldHRlci1zcGFjaW5nOiAzcHg7XG4gIGxpbmUtaGVpZ2h0OiAxLjNlbTtcbiAgcGFkZGluZzogMWVtIDEuMjVlbTtcbiAgdGV4dC1kZWNvcmF0aW9uOiBub25lO1xuICB0ZXh0LXRyYW5zZm9ybTogdXBwZXJjYXNlO1xuICB3aWR0aDogMTQwcHg7XG59XG5cbi5idXR0b24uZGFyayB7XG4gIGJhY2tncm91bmQ6ICNmZmZmZmY7XG4gIGNvbG9yOiAjNzViZWFhO1xufVxuXG5AbWVkaWEgKG1heC13aWR0aDogNTY4cHgpIHtcbiAgLmJ1dHRvbiB7XG4gICAgZGlzcGxheTogYmxvY2s7XG4gICAgbWFyZ2luOiAxZW0gYXV0byAwO1xuICB9XG59XG5cbi5oZXJvLXNjcm9sbCB7XG4gIGhlaWdodDogMTAwJTtcbiAgb3ZlcmZsb3c6IGF1dG87XG4gIC13ZWJraXQtb3ZlcmZsb3ctc2Nyb2xsaW5nOiB0b3VjaDtcbiAgd2lkdGg6IDEwMCU7XG59XG5cbi5oZXJvLW91dGVyIHtcbiAgYm94LXNpemluZzogYm9yZGVyLWJveDtcbiAgZGlzcGxheTogdGFibGU7XG4gIGhlaWdodDogMTAwJTtcbiAgcGFkZGluZzogMjBweCAwO1xuICB3aWR0aDogMTAwJTtcbn1cblxuLmhlcm8tb3V0ZXIgLmhlcm8taW5uZXIge1xuICBtYXJnaW46IDAgYXV0byAxZW07XG4gIHRleHQtYWxpZ246IGNlbnRlcjtcbiAgd2lkdGg6IDU0MHB4O1xufVxuXG5AbWVkaWEgKG1heC13aWR0aDogNjAwcHgpIHtcbiAgLmhlcm8tb3V0ZXIgLmhlcm8taW5uZXIge1xuICAgIHdpZHRoOiAzNDBweDtcbiAgfVxufVxuXG5AbWVkaWEgKG1heC13aWR0aDogMzYwcHgpIHtcbiAgLmhlcm8tb3V0ZXIgLmhlcm8taW5uZXIge1xuICAgIHdpZHRoOiAyMDBweDtcbiAgfVxufVxuXG4uaGVyby1vdXRlciAuaGVyby1pbm5lciBoMSxcbi5oZXJvLW91dGVyIC5oZXJvLWlubmVyIGgyLFxuLmhlcm8tb3V0ZXIgLmhlcm8taW5uZXIgaDMsXG4uaGVyby1vdXRlciAuaGVyby1pbm5lciBwIHtcbiAgY29sb3I6ICNmZmZmZmY7XG4gIGZvbnQtd2VpZ2h0OiBub3JtYWw7XG4gIGxpbmUtaGVpZ2h0OiAxO1xuICBtYXJnaW46IDAgMCAyMHB4O1xufVxuXG4uaGVyby1vdXRlciAuaGVyby1pbm5lciBoMyB7XG4gIGZvbnQtc2l6ZTogMS4zZW07XG4gIHBhZGRpbmctdG9wOiAxM3B4O1xufVxuXG4uaGVyby1vdXRlciAuaGVyby1pbm5lciBoMSB7XG4gIHBhZGRpbmctdG9wOiAxMHB4O1xufVxuXG4uaGVyby1vdXRlciAuaGVyby1pbm5lciA+ICoge1xuICBvcGFjaXR5OiAwLjM7XG4gIHBvaW50ZXItZXZlbnRzOiBub25lO1xuICB0cmFuc2l0aW9uOiBvcGFjaXR5IDAuNHM7XG59XG5cbmJvZHk6bm90KC5zaGVwaGVyZC1hY3RpdmUpIC5oZXJvLW91dGVyIC5oZXJvLWlubmVyID4gKiB7XG4gIG9wYWNpdHk6IDE7XG4gIHBvaW50ZXItZXZlbnRzOiBhdXRvO1xufVxuXG4uaGVyby1vdXRlciAuaGVyby1pbm5lciAuc2hlcGhlcmQtdGFyZ2V0LnNoZXBoZXJkLWVuYWJsZWQge1xuICBvcGFjaXR5OiAxO1xuICBwb2ludGVyLWV2ZW50czogYXV0bztcbn1cblxuLmhlcm8tb3V0ZXIgLmhlcm8tZm9sbG93dXAge1xuICBwYWRkaW5nLXRvcDogMjBweDtcbn1cblxuLnNoZXBoZXJkLWVsZW1lbnQuc2hlcGhlcmQtdHJhbnNwYXJlbnQtdGV4dCAuc2hlcGhlcmQtdGV4dCB7XG4gIGNvbG9yOiAjM2I3NDRmO1xufVxuXG4uc2hlcGhlcmQtZWxlbWVudCAuc2hlcGhlcmQtY29udGVudCB7XG4gIG1heC13aWR0aDogMTAwJTtcbiAgd2lkdGg6IDQwMHB4O1xufVxuXG4uc2hlcGhlcmQtZWxlbWVudCAuc2hlcGhlcmQtY29udGVudCBhIHtcbiAgY29sb3I6IFwiaW5oZXJpdFwiO1xufVxuXG4uc2hlcGhlcmQtZWxlbWVudCAuc2hlcGhlcmQtY29udGVudCBmb290ZXIgLnNoZXBoZXJkLWJ1dHRvbnMgbGkgLnNoZXBoZXJkLWJ1dHRvbi1leGFtcGxlLXByaW1hcnkge1xuICBiYWNrZ3JvdW5kOiAjNTVhODkyO1xufVxuXG5wcmUge1xuICBib3JkZXI6IDFweCBzb2xpZCByZ2JhKDAsIDAsIDAsIDAuMTUpO1xuICBsaW5lLWhlaWdodDogMS40ZW07XG59XG4iXX0= */ No newline at end of file |
| @@ -0,0 +1,71 @@ | |||
| export class Evented { | |||
| constructor(/* options = {}*/) { | |||
Member
There was a problem hiding this comment.
if we're not using constructors or static methods, why use a class? I'd say export a default object.
src/js/shepherd.js
Outdated
|
|
||
| } | ||
|
|
||
| class Step extends Evented { |
Member
There was a problem hiding this comment.
nvm, I guess this extension is the reason for now. Should consider that overall later.
|
|
||
| export function matchesSelector(el, sel) { | ||
| let matches; | ||
| if (!isUndefined(el.matches)) { |
chuckcarpenter
approved these changes
Aug 15, 2018
Member
chuckcarpenter
left a comment
chuckcarpenter
left a comment
There was a problem hiding this comment.
Comments for future TODOs mostly. LGTM!
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.