Skip to content

Allow exit animations to play before step tooltip disappears.#279

Merged
RobbieTheWagner merged 3 commits intomasterfrom
support-waiting-on-show
Oct 19, 2018
Merged

Allow exit animations to play before step tooltip disappears.#279
RobbieTheWagner merged 3 commits intomasterfrom
support-waiting-on-show

Conversation

@BrianSipple
Copy link
Copy Markdown
Contributor

Closes #277

This removes our own manual management of this.el's appearance/presence
in the DOM -- since tippy is handling it already.

This allows the tooltip's exit animation to play, as opposed to having the element disappear instantly before we even call tippy.hide.

@BrianSipple BrianSipple force-pushed the support-waiting-on-show branch 2 times, most recently from 9bb47bc to 4c0a30a Compare October 17, 2018 02:36
@BrianSipple BrianSipple changed the title Allow exit animations to play before step tooltip disappears. [WIP] Allow exit animations to play before step tooltip disappears. Oct 17, 2018
@BrianSipple BrianSipple force-pushed the support-waiting-on-show branch 2 times, most recently from 8e4f85a to 3283f4f Compare October 17, 2018 21:47
@BrianSipple BrianSipple changed the title [WIP] Allow exit animations to play before step tooltip disappears. Allow exit animations to play before step tooltip disappears. Oct 17, 2018
@BrianSipple BrianSipple force-pushed the support-waiting-on-show branch 2 times, most recently from 811a82f to 7b02b46 Compare October 17, 2018 22:52
Closes #277

This removes our own manual management of `this.el`'s appearance/presence
in the DOM -- since tippy is handling it already.
@BrianSipple BrianSipple force-pushed the support-waiting-on-show branch 3 times, most recently from aa69177 to 1a74ed0 Compare October 18, 2018 04:51
Copy link
Copy Markdown
Contributor Author

@BrianSipple BrianSipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got a bit harrier than I anticipated -- for a few reasons:

As I started testing the step cleanup process to account for the Step.hide changes, I realized that some of our unit test blocks weren't properly tearing down their Tour instance -- so that accounts for some of the structural changes.

I also moved the Step cleanup tests out of Cy and into Mocha to try and keep it as focused as possible. (I continue to have issues with Cy finding elements that "should not exist" because they did exist at some point during the test 😕).

Finally, I refactored done so that it calls destroy on the current step instead of hide, while also separating currentStep.hide outside the concern of Tour._setupActiveTour.

@BrianSipple BrianSipple force-pushed the support-waiting-on-show branch 2 times, most recently from 8dba962 to 2cd8c07 Compare October 18, 2018 18:04
@BrianSipple BrianSipple force-pushed the support-waiting-on-show branch from 2cd8c07 to 2f7e6a0 Compare October 18, 2018 21:45
@BrianSipple BrianSipple force-pushed the support-waiting-on-show branch from 0fd8650 to 325b372 Compare October 18, 2018 22:52
@RobbieTheWagner RobbieTheWagner merged commit a79a5a1 into master Oct 19, 2018
@RobbieTheWagner RobbieTheWagner deleted the support-waiting-on-show branch October 19, 2018 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants