Use rollup instead of webpack#309
Merged
RobbieTheWagner merged 21 commits intomasterfrom Jan 12, 2019
Merged
Conversation
6fd9e5c to
451f292
Compare
chuckcarpenter
approved these changes
Jan 12, 2019
Member
chuckcarpenter
left a comment
There was a problem hiding this comment.
This LGTM, but what were the reasons again for moving to Jest?
Member
Author
|
@chuckcarpenter moving to Jest was mostly just because it kind of handles everything out of the box. We had a lot of custom stuff to get mocha running, and Jest just needs to run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo:
outputentries to output cjs, esm, umd, etc. and set the corresponding package.json fields formain,browser,moduleetc