Skip to content

Use rollup instead of webpack#309

Merged
RobbieTheWagner merged 21 commits intomasterfrom
rollup-spike
Jan 12, 2019
Merged

Use rollup instead of webpack#309
RobbieTheWagner merged 21 commits intomasterfrom
rollup-spike

Conversation

@RobbieTheWagner
Copy link
Copy Markdown
Member

@RobbieTheWagner RobbieTheWagner commented Jan 7, 2019

Todo:

  • Get Stylelint working again
  • Fix coverage calculations and ignore files we don't care about
  • Explore using multiple output entries to output cjs, esm, umd, etc. and set the corresponding package.json fields for main, browser, module etc
  • Use plain css for docs styles
  • Figure out why styles/transitions are buggy when clicking next/previous in tours. Seems something is wrong with the output somewhere.

@RobbieTheWagner RobbieTheWagner changed the title [WIP] Use rollup instead of webpack Use rollup instead of webpack Jan 11, 2019
Copy link
Copy Markdown
Member

@chuckcarpenter chuckcarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but what were the reasons again for moving to Jest?

@RobbieTheWagner
Copy link
Copy Markdown
Member Author

@chuckcarpenter moving to Jest was mostly just because it kind of handles everything out of the box. We had a lot of custom stuff to get mocha running, and Jest just needs to run jest

@RobbieTheWagner RobbieTheWagner merged commit 3b35be5 into master Jan 12, 2019
@RobbieTheWagner RobbieTheWagner deleted the rollup-spike branch January 12, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants