Add option to specify container element for the modal#474
Merged
RobbieTheWagner merged 1 commit intoshipshapecode:masterfrom Aug 1, 2019
Merged
Add option to specify container element for the modal#474RobbieTheWagner merged 1 commit intoshipshapecode:masterfrom
RobbieTheWagner merged 1 commit intoshipshapecode:masterfrom
Conversation
RobbieTheWagner
requested changes
Aug 1, 2019
| * @param {boolean} options.useModalOverlay Whether or not steps should be placed above a darkened | ||
| * modal overlay. If true, the overlay will create an opening around the target element so that it | ||
| * can remain interactive | ||
| * @param {HTMLElement} options.modalContainer Optional container Element for the modal. |
Member
There was a problem hiding this comment.
Can you also document this here please? https://github.com/shipshapecode/shepherd/blob/master/docs-src/tutorials/02-usage.md
Member
There was a problem hiding this comment.
I will document it, no worries!
RobbieTheWagner
changed the title
RobbieTheWagner
approved these changes
Aug 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't always want to append to modal to the body, in some cases we need it to be child of other container element. (for steps we have appendTo tippy option).