Skip to content

Fix applying tippyOptions#475

Merged
RobbieTheWagner merged 1 commit intoshipshapecode:masterfrom
genadis:max-width-fix
Aug 1, 2019
Merged

Fix applying tippyOptions#475
RobbieTheWagner merged 1 commit intoshipshapecode:masterfrom
genadis:max-width-fix

Conversation

@genadis
Copy link
Copy Markdown
Contributor

@genadis genadis commented Aug 1, 2019

tippy options are already applied at: https://github.com/shipshapecode/shepherd/blob/master/src/js/utils/general.js#L179

the deleted lines essentially do something like:

Object.assign({a: 'hello', b: 'bye'}, '400px')

which results in:

{0: "4", 1: "0", 2: "0", 3: "p", 4: "x", a: "hello", b: "bye"}

getVariables import not used (there is error at compile time)

@RobbieTheWagner RobbieTheWagner merged commit dccb74f into shipshapecode:master Aug 1, 2019
@RobbieTheWagner RobbieTheWagner changed the title fix applying tippyOptions Fix applying tippyOptions Aug 1, 2019
@genadis genadis deleted the max-width-fix branch August 1, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants