Added the correct this context to StepOption 'when' functions#995
Merged
RobbieTheWagner merged 1 commit intoshipshapecode:masterfrom Jun 3, 2020
Merged
Added the correct this context to StepOption 'when' functions#995RobbieTheWagner merged 1 commit intoshipshapecode:masterfrom
RobbieTheWagner merged 1 commit intoshipshapecode:masterfrom
Conversation
With accordance to https://github.com/shipshapecode/shepherd/blob/ad5b9b0daa3a2db1a507b70f6f4d6b5620add40d/src/js/step.js#L332 the "this" context is set to the Step
RobbieTheWagner
approved these changes
Jun 3, 2020
Contributor
Author
|
Ahh, I was unaware of actions. As the code was not in the JS but in the svelte and I had never used svelte before. Which would make the Typescript - action?: (() => void);
+ action?: ((this: Tour) => void); |
Member
|
@WORMSS yeah, that is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update step.d.ts
With accordance to
shepherd/src/js/step.js
Line 332 in ad5b9b0