Skip to content

Add version cmd #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

qu1queee
Copy link
Contributor

@qu1queee qu1queee commented Apr 2, 2022

Changes

Enable users to see a version on the ship binary. This will be only set when consuming a ship from our releases.

This adds a new main cmd and the necessary changes in the goreleaser to compile the binary with the current version(based on the latest git tag).

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Add version cmd.

Enable users to see current shp version
@qu1queee qu1queee force-pushed the qu1queee/version_cmd branch from 2f0cdc6 to fa98e67 Compare April 2, 2022 20:10
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.9.0 milestone Apr 4, 2022
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2022
@openshift-merge-robot openshift-merge-robot merged commit 50c09e6 into shipwright-io:main Apr 4, 2022
@qu1queee qu1queee deleted the qu1queee/version_cmd branch April 5, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants