Skip to content

Add verify action #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2021
Merged

Add verify action #75

merged 2 commits into from
Nov 12, 2021

Conversation

SaschaSchwarze0
Copy link
Member

Changes

Duplicating the verify action from the build repo into the CLI and addressing the findings. Most funny one: we had a buildrun delete command that we did not expose. :-)

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

You can now delete BuildRuns

@SaschaSchwarze0 SaschaSchwarze0 added kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 9, 2021
@openshift-ci openshift-ci bot requested review from alicerum and sbose78 November 9, 2021 10:47
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-verify branch 2 times, most recently from 786d176 to dc29c5a Compare November 9, 2021 10:55
HeavyWombat
HeavyWombat approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HeavyWombat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2021
@gabemontero
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2021
@openshift-merge-robot openshift-merge-robot merged commit b68be61 into shipwright-io:main Nov 12, 2021
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.7.0 milestone Dec 13, 2021
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-verify branch January 12, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeavyWombat HeavyWombat HeavyWombat approved these changes

@alicerum alicerum Awaiting requested review from alicerum

@sbose78 sbose78 Awaiting requested review from sbose78

Assignees

@gabemontero gabemontero

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note
Projects
None yet
Milestone
release-v0.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SaschaSchwarze0 @gabemontero @HeavyWombat @openshift-merge-robot