Skip to content

modified lots of ui design #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 15, 2023
Merged

modified lots of ui design #35

merged 13 commits into from
Feb 15, 2023

Conversation

BH4HPA
Copy link
Member

@BH4HPA BH4HPA commented Feb 11, 2023

0x01 on ScheduleTable

  • support multi-themes
  • add '糖果' theme
    • add border-radius and margin
    • remove border
    • modified coloring scheme

before

image.png

after

image.png

202302122319.gif

0x02 on ReservedClassesList

  • redesign the usage of CourseColor
  • change the text for the RemoveReservedClass button
  • bolden courseName text
  • add space between every credit and '学号' text
  • add CopyCourseId button for copying course id easierly

before

image.png

after

image.png

@BH4HPA BH4HPA requested review from ZKLlab and chinggg February 11, 2023 06:00
@BH4HPA
Copy link
Member Author

BH4HPA commented Feb 11, 2023

demo is available on https://xk.r-ay.cn/

@Errant404
Copy link
Member

Instead of modifying the theme, it might be more popular to add a switch theme function (personal opinion, because I still like the original style🤪)

@chinggg
Copy link
Contributor

chinggg commented Feb 12, 2023

Thanks for your work. Since I am no longer taking courses here, I am OK with any theme changes as long as they improve user experience.

when the width is not enough, its position was unexpected.
@BH4HPA
Copy link
Member Author

BH4HPA commented Feb 12, 2023

@Errant404 ok now I have added the switch theme function :D

Copy link
Member

@Errant404 Errant404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! 😍

Copy link
Contributor

@chinggg chinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CopyCourseId button should be useful. Theme switching is also a good job! Maybe we can also support multiple semesters in the future as #34 proposed. But that may require much refactoring or even a new version.

@BH4HPA
Copy link
Member Author

BH4HPA commented Feb 13, 2023

@chinggg i'm afraid to merge now because i don't know whether ci failed will influence build or deployment by github action after merging, does this repository be deployed by github action automatically or not? (ci failed may due to using yarn 2 or some dependencies updated)

@BH4HPA
Copy link
Member Author

BH4HPA commented Feb 13, 2023

Adding 'engines ignore' due to ci failing and can't be fixed (vuejs/vue-cli#7116) seems ok now. The deployment should be completed by anyone who has access.

@chinggg
Copy link
Contributor

chinggg commented Feb 13, 2023

The website will be deployed by @ZKLlab

@ZKLlab
Copy link
Member

ZKLlab commented Feb 13, 2023

@ENDsoft233 Thanks a lot for your valuable contribution to this project. I will review the code and get back to you as soon as possible.

Copy link
Member

@ZKLlab ZKLlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已 review,感谢 PR,主要有以下几点辛苦看看:

  1. CopyCourseId.js、UseScheduleTableTheme.js 移到 src/mixins/common 目录下;
  2. Storage 存储当前主题建议使用主题名称,如 classic 和 candy,同时需做好匹配不到主题的兜底;
  3. 一些样式上的修改建议

Copy link
Member

@ZKLlab ZKLlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts 里使用环境变量要用 cross-env 库支持 Windows 平台

@BH4HPA BH4HPA requested a review from ZKLlab February 15, 2023 10:01
Copy link
Member

@ZKLlab ZKLlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you, I will merge it into the main branch. The pipeline will automatically build and deploy the website to the pre-production environment at https://pre.xk.shuosc.com. Please check if it meets the expected outcome and works properly. Once confirmed, I will release the website to the production environment.

@ZKLlab ZKLlab merged commit 67a5ccf into shuosc:main Feb 15, 2023
@BH4HPA
Copy link
Member Author

BH4HPA commented Feb 15, 2023

I've checked the following changes and all seems ok.

  • theme selection and its storage
  • new CourseColor UI
  • CopyCourseId Function

It's time to release it, excited! XD
Thanks for your approval! @ZKLlab

@ZKLlab
Copy link
Member

ZKLlab commented Feb 15, 2023

@ENDsoft233 Great! Thank you for confirming. I have now completed the deployment. If you encounter any issues or have further feedback, please do not hesitate to let me know. Also, you can check the deployment log of the production environment at https://github.com/shuosc/shu-scheduling-helper/deployments/activity_log?environment=production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants