Conversation
Closes simonw#15
|
This is great and saves me a ton of time! Thank you for opening the pull request. |
|
FYI there is a degenerate behavior in this patch when no files are passed in. Not sure there is too much of an appetite for this to be merged in. Trying to read Simon's mind, the existing implementation probably gives comparable results while using less tokens and being more simple. But I'll push another commit to better handle that case anyway. |
|
Yeah let’s fix that and ship this! |
files_to_prompt/cli.py
Outdated
| if not ignore_gitignore: | ||
| gitignore_rules.extend(read_gitignore(os.path.dirname(path))) | ||
| if xml and path == paths[0]: | ||
| click.echo("Here are some documents for you to reference for your task:") |
There was a problem hiding this comment.
I don’t like including this prompt here
|
The fact that this doesn’t guarantee a valid XML document (that could then be handled by an XML parser) really bugs me! A few options:
I’m leaning towards 2. |
This feels like a good compromise and opens the door for a valid I have tested with both valid and Claude's XML, and I don't see any noticeable improvements either way. They have other features where randomly dropping in an xml tag has meaning in an otherwise other text sea of chaos. |
Refs simonw#16 (comment) Also removed additional prompt text, refs simonw#16 (comment)
Closes #15