Repository navigation
Fix endpoint additions to flow-style YAML lists - #1845
Merged
simonw merged 3 commits intoNov 3, 2026
Merged
Conversation
simonw
added a commit
that referenced
this pull request
Nov 3, 2026
Removing the last saved endpoint leaves "[]" in extra-openai-models.yaml. Since #1845 the next llm openai endpoint add inserts into that flow-style list, so the file and every later addition ended up on one long line. A file containing exactly "[]" is now replaced with a block style list instead. Bracketed lists with any other content, such as comments, still use the flow-style insertion that preserves them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
simonw
added a commit
that referenced
this pull request
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the last saved endpoint leaves
[]inextra-openai-models.yaml. Adding another endpoint then reported success but appended a block entry after the closing bracket, leaving invalid YAML and preventing saved models from loading.Insert new records inside flow-style lists instead, preserving existing records, comments, formatting, trailing commas, and aliases. The regression exercises
add→remove→add→listthrough the CLI, with additional coverage for hand-written flow-style configuration.Validation: full pytest suite, Black, Ruff, mypy, Cog, package build, and the plugin-loading smoke test.
AI assistance: OpenAI Codex assisted with investigation, implementation, and validation.