Skip to content

Non-Empty String Type #946

@roryabraham

Description

@roryabraham

It seems pretty common that we run into issues with a string being empty when it's not supposed to. These are some common issues I see:

  1. An API parameter is meant to be a string, but an empty string isn't valid.
  2. We mean to default an empty string to something else, such as '-1', but our ESLint config encourages us to use nullish coalescing ?? instead of ||. Obviously these don't work the same in cases where you have an empty string.

anyways, my suggestion is to create a type called NonEmptyString. According to this Stackoverflow, the best way to accomplish this is with a very verbose template literal with any non-empty character followed by a string

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions