Jsonify: handle unknown as JsonValue#1206
Merged
sindresorhus merged 3 commits intosindresorhus:mainfrom Aug 24, 2025
Merged
Conversation
GerkinDev
commented
Jul 28, 2025
| [Key in keyof T]: IsAny<T[Key]> extends true | ||
| ? Key | ||
| : undefined extends T[Key] | ||
| : IsUnknown<T[Key]> extends true ? Key : undefined extends T[Key] |
Contributor
Author
There was a problem hiding this comment.
Given how any is handled I suppose it makes sense
Owner
Let’s not preserve unknown. Jsonify’s job is to produce something assignable to JsonValue, so mapping unknown to JsonValue keeps the contract clear and makes it more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1195 by mapping
unknowntoJsonValue. If requested, I can preserveunknownas mentioned in the issueHad a bit of struggles with the test
because
infered
{F: 'some value', R: unknown[]}, thus the arguably not ideal hack. Yet, it passes all the tests and it somewhat makes sense.This problem looks like a known issue in TS tuples handling & intersection with arrays, but depending on the POV, it may be more of a feature than a bug.