-
-
Notifications
You must be signed in to change notification settings - Fork 679
Fix: is-equal fails in some cases when intersecting wrapped types (F<[A]> & G<[A]>)
#1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sindresorhus
merged 14 commits into
sindresorhus:main
from
taiyakihitotsu:fix/equal-tuple-case
Sep 20, 2025
+70
−14
Merged
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
554bd00
test: add the edge case for is-equal: ([A, B] extends infer Arg ? IsE…
taiyakihitotsu 6d0462c
fix: make is-equal recursive to fix this case: ([A, B] extends infer …
taiyakihitotsu 9c8550b
refactor: deleting export. renaming _NonNever to _NonNeverId. rewriti…
taiyakihitotsu 841725a
test: add baseline cases for IsEqual
taiyakihitotsu da83b2f
refactor: fix typo and renaming test cases.
taiyakihitotsu 3296abc
docs: fix incorrect link in comment
taiyakihitotsu b92adee
refactor: apply @som-sm's suggestion -- use BuildTuple in baseline ca…
taiyakihitotsu b9e2a8d
update: #1231 -- simplify definition
taiyakihitotsu d25a7f2
test: add duplicated intersection case
taiyakihitotsu 86c537c
refactor: simplify definition of IsEqual
taiyakihitotsu 7c9a956
test: fix type issues by using declare const
taiyakihitotsu 5458b71
test: fix test cases
som-sm d848084
test: add more cases
som-sm d79a866
test: simplify tuple intersection test
taiyakihitotsu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.