Merged
Conversation
som-sm
requested changes
Mar 14, 2026
Collaborator
som-sm
left a comment
There was a problem hiding this comment.
Needs more test cases, refer to the test cases for AllExtend.
Collaborator
Yeah, I agree. I guess it makes more sense to first expose a |
Collaborator
|
@salisbury-espinosa |
Contributor
Author
done @som-sm |
som-sm
approved these changes
Mar 17, 2026
Collaborator
som-sm
left a comment
There was a problem hiding this comment.
PR LGTM. Not too sure about the naming, here are some alternative AI suggestions:
OrAllOrN
Contributor
Author
|
OrMultiple => OrAll ✅ @som-sm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perhaps it would be ideal to create an analogue of AllExtend -
AtLeastOneExtendand then
OrMultiple<T> => AtLeastOneExtend<T, true>just like we can do now AndMultiple, for exampleAndMultiple<T extends readonly boolean[]> = AllExtend<T, true>;