Skip to content

submit not receive time beat ratio any more #156

Open
@zcmartian

Description

@zcmartian

when i use submit command, it doesn't reveive time beat ratio any more. instead i receive a message saying "[WARN] Failed to get submission beat ratio."

Activity

smrook

smrook commented on Feb 2, 2019

@smrook

leetcode has changed the chart field name. In plugins/leetcode.js on line 339, need to update
re = body.match(/distribution_formatted:\s('[^']+')/);
to
re = body.match(/runtimeDistributionFormatted:\s('[^']+')/);

Another suggestion is to include the distribution bucket of the submission itself while counting the beating percentile to make it more align with what we see from the web page, which is in commands/submit.js on line 79, change
if (parseFloat(score[0]) > myRuntime)
to
if (parseFloat(score[0]) >= myRuntime)

Thanks~

skygragon

skygragon commented on Feb 3, 2019

@skygragon
Owner

@smrook sounds great! would you mind sharing your fixes in the next release?

added a commit that references this issue on Feb 3, 2019
ketankr9

ketankr9 commented on Mar 2, 2019

@ketankr9

I am still facing this issue.

[WARN] Failed to get submission beat ratio.

Could someone please release a new All In One binary.
Thanks

cosmozhang

cosmozhang commented on Jun 8, 2019

@cosmozhang

Same bug here.

edte

edte commented on Jul 11, 2022

@edte

same bug here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @skygragon@zcmartian@cosmozhang@smrook@ketankr9

        Issue actions

          submit not receive time beat ratio any more · Issue #156 · skygragon/leetcode-cli