Skip to content

feat. ssh prefix configuration #5996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ajay-Satish-01
Copy link
Contributor

@Ajay-Satish-01 Ajay-Satish-01 commented Jun 13, 2025

Related to #5987

Added a ssh constant that can be configured and used instead of ssh

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@Ajay-Satish-01
Copy link
Contributor Author

@kyuds Please let me know if this is what you expect.

Thanks

@kyuds
Copy link
Collaborator

kyuds commented Jun 15, 2025

Hey @Ajay-Satish-01 thank you so much for contributing! Right now, SSH node pools is in too much active development, so the introduction of a new constant might conflict with a lot of development branches... Could I circle back to you in the near future about this? I feel that this is definitely in need, so I'll make sure to remember! Thank you so much!

@Ajay-Satish-01
Copy link
Contributor Author

Hey @Ajay-Satish-01 thank you so much for contributing! Right now, SSH node pools is in too much active development, so the introduction of a new constant might conflict with a lot of development branches... Could I circle back to you in the near future about this? I feel that this is definitely in need, so I'll make sure to remember! Thank you so much!

Sure. Thanks for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants