Skip to content

[k8s] Handle invalid kubeconfig parsing #6071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 25, 2025
Merged

[k8s] Handle invalid kubeconfig parsing #6071

merged 6 commits into from
Jun 25, 2025

Conversation

kyuds
Copy link
Collaborator

@kyuds kyuds commented Jun 24, 2025

Fixes #5989

Basically we will proceed by uploading the invalid kubeconfig, and throw the user a warning saying that things might not go as expected if they are indeed using k8s infra.

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@kyuds kyuds requested a review from romilbhardwaj June 24, 2025 01:19
@kyuds
Copy link
Collaborator Author

kyuds commented Jun 24, 2025

/smoke-test --kubernetes

@kyuds kyuds requested a review from romilbhardwaj June 24, 2025 01:47
@kyuds kyuds enabled auto-merge (squash) June 24, 2025 01:52
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kyuds!

@kyuds kyuds merged commit 257f2b7 into master Jun 25, 2025
15 checks passed
@kyuds kyuds deleted the kyuds/k8sconfig branch June 25, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[k8s] Invalid kubeconfig causes unexpected SkyPilot error
3 participants