add -o json option to cost-report#9504
Open
MaxVanDijck wants to merge 4 commits intoskypilot-org:masterfrom
Open
add -o json option to cost-report#9504MaxVanDijck wants to merge 4 commits intoskypilot-org:masterfrom
MaxVanDijck wants to merge 4 commits intoskypilot-org:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements JSON output support for the sky cost-report command, including the necessary CLI flag and logic to format cluster records as JSON. It also adds comprehensive unit tests to verify the new functionality. Review feedback suggests moving a pylint suppression comment to the correct parameter and providing a default value for the output_format argument to ensure consistency when the function is called programmatically.
Michaelvll
reviewed
May 5, 2026
Collaborator
Michaelvll
left a comment
There was a problem hiding this comment.
Thanks for the contribution @MaxVanDijck! It looks mostly good to me, except for the resource output format (see comment below)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a
-o jsonoutput for the cost-report cli to address #9499 (comment)Added unittests for the new json output which are similar to the other unittests for json output
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)