Support `extensions` property #19

Closed

Closed

Support extensions property#19

Contributor

As graphql-js now has a dedicated mechanism for storing additional metadata, we should use that to place and read complexity info from constructed types:
graphql/graphql-js#2097

added a commit that references this issue

on Sep 23, 2019

Add fieldExtensionsEstimator, deprecate fieldConfigEstimator #19

mentioned this

on Sep 23, 2019

Field extension estimator #19 #20

Collaborator

This is great news... thanks for raising the issue! I added a new fieldExtensionsEstimator and added deprecation notices to the fieldConfigEstimator so we can remove this in future releases (plus those hacky TypeScript extensions of the GraphQL types we currently have).

ContributorAuthor

those hacky TypeScript extensions of the GraphQL types we currently have

They are not so bad, it's better to provide typings for the properties because this will check the signature of function which results in better DX. However I haven't tried to merge declarations for extenstions as they might be typed as record with any 😕

added a commit that references this issue

Merge pull request #20 from slicknode/feature/field-extension-estimator

Collaborator

I just published a new version v0.4.0 with this feature

closed this as completed

mentioned this

Upgrade graphql-query-complexity dependency and related code MichalLytek/type-graphql#437

mentioned this

on Feb 23, 2020

[Snyk] Upgrade graphql-query-complexity from 0.2.2 to 0.4.1 saurabharch/type-graphql#3

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

No labels

No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Participants