Skip to content

Add a reset to remove bold when not asked #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

utix
Copy link
Contributor

@utix utix commented Sep 12, 2022

Some part are bold even if not configure to be

func on this example:

image

Reseting ascii at the begining fixes it

@utix utix changed the base branch from master to next September 12, 2022 16:18
@scottchiefbaker
Copy link
Contributor

Is the only place this is affecting the "last function" fragment? If so, it probably makes more sense to JUST reset that one, instead of EVERYTHING in git_ansi_color()?

@utix
Copy link
Contributor Author

utix commented Sep 12, 2022

Hard to check all combination, should I check on master or next branch ?
For info bright, seems broken on next branch, since 754f9df with git bisec
for example birghtyellow is not working on func

@utix
Copy link
Contributor Author

utix commented Sep 12, 2022

@scottchiefbaker
Copy link
Contributor

This looks innocent enough, and seems like a good solution.

@scottchiefbaker scottchiefbaker merged commit 0c87707 into so-fancy:next Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants