Skip to content

bump required perl version #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2022
Merged

bump required perl version #447

merged 1 commit into from
Nov 3, 2022

Conversation

morbeo
Copy link
Contributor

@morbeo morbeo commented Nov 2, 2022

With perl 5.12:

morbeo@qa:~ perl -v

This is perl 5, version 12, subversion 5 (v5.12.5) built for x86_64-linux
(with 1 registered patch, see perl -V for more detail)

Copyright 1987-2012, Larry Wall

Perl may be copied only under the terms of either the Artistic License or the
GNU General Public License, which may be found in the Perl 5 source kit.

Complete documentation for Perl, including FAQ lists, should be found on
this system using "man perl" or "perldoc perl".  If you have access to the
Internet, point your browser at http://www.perl.org/, the Perl Home Page.

morbeo@qa:~ diff-so-fancy
Bareword found where operator expected at /home/morbeo/bin/diff-so-fancy line 624, near "s/^\s*//u"

With perl 5.14

morbeo@qa:~ perlbrew switch perl-5.14.4
morbeo@qa:~ diff-so-fancy
Diff-so-fancy: https://github.com/so-fancy/diff-so-fancy
Version      : 1.4.2

Usage:

git diff --color | diff-so-fancy         # Use d-s-f on one diff
cat diff.txt | diff-so-fancy             # Use d-s-f on a diff/patch file
diff -u one.txt two.txt | diff-so-fancy  # Use d-s-f on unified diff output

diff-so-fancy --colors                   # View the commands to set the recommended colors
diff-so-fancy --set-defaults             # Configure git-diff to use diff-so-fancy and suggested colors
diff-so-fancy --patch                    # Use diff-so-fancy in patch mode (interoperable with `git add --patch`)

# Configure git to use d-s-f for *all* diff operations
git config --global core.pager "diff-so-fancy | less --tabs=4 -RFX"

# Configure git to use d-s-f for `git add --patch`
git config --global interactive.diffFilter "diff-so-fancy --patch"

@morbeo morbeo changed the base branch from master to next November 2, 2022 13:51
@scottchiefbaker
Copy link
Contributor

Perl 5.14 was released in 2011, so bumping to a newer required version isn't an issue (for me).

I'm fine with the content in this PR, but it looks like a couple of other of my commits from somewhere got pulled in to this PR as well. If you can simplify this down to just the use v5.14 statement I'll land this.

@morbeo
Copy link
Contributor Author

morbeo commented Nov 3, 2022

Thank you for the prompt reply. I eagerly created the PR to master, but then I noticed in the Contribution section they should be to next. When I switched your commits were included. Should be ok now.

@scottchiefbaker scottchiefbaker merged commit ac0cbe2 into so-fancy:next Nov 3, 2022
@scottchiefbaker
Copy link
Contributor

Just out of curiosity... how did you run in to this? What version of Perl are you running?

@morbeo
Copy link
Contributor Author

morbeo commented Nov 4, 2022

At work I use CentOS 6 VMs with perl 5.10

@morbeo morbeo deleted the bump_perl_version_requirement branch November 4, 2022 08:49
@scottchiefbaker
Copy link
Contributor

OOoof, that's rough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants