Don't build the extension on Windows#162
Merged
tarcieri merged 1 commit intosocketry:masterfrom Aug 2, 2017
Merged
Conversation
The extension can be build on Windows but it doesn't work. All connection related tests fail. So it's a waste of time to build the extension, which isn't used. This also removes the patching of the makefile, because it isn't necessary on any recent ruby version, but breaks the extension, so that it can't be loaded by ruby. So this should be removed anyway. I tested this on ruby-2.2-x86 and 2.4-x64. See also socketry#161
Contributor
|
@MSP-Greg think this is the way to go for now? |
Closed
Contributor
Most of the time, and especially when dealing with C and windows/mingw, I'll always defer to @larskanis. I haven't had time to check anything, but it seems something additional is needed if Appveyor's failing? Also, I'm wondering about the commits by unak / usa in June. Maybe he was just patching so it would compile, but still using the 'pure-ruby' version as with a MinGW build... I'll be back... |
larskanis
force-pushed
the
dont-build-ext-on-windows
branch
from
4edab0a to
9e7b5e6
Compare
Contributor
Author
|
I fixed the appveyor failure and unified the windows test in |
Contributor
|
@larskanis thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension can be build on Windows but it doesn't work. All connection related tests fail. So it's a waste of time to build the extension, which isn't used.
This also removes the patching of the makefile, because it isn't necessary on any recent ruby version, but breaks the extension, so that it can't be loaded by ruby. So this should be removed anyway.
I tested this on ruby-2.2-x86 and 2.4-x64.
See also #161