-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix possible web crashes #3553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix possible web crashes #3553
Conversation
Hi @billouboq! First of all, thanks for this PR! Is there any stack trace for the first error? Looking at the code, situation where last coordinates are |
@m-bert Unfortunatly, we couldn't have more details about that, it was only showing in Sentry and not a single user reported an issue, and we cannot reproduce on our side |
Okay, I'll try to find out what is the root cause. What Gesture Handler version do you use? I assume it was reported on 2.25.0 |
Hi again @billouboq! Unfortunately I was not able to reproduce it, though I think it may be caused by one of the following:
For now I can't see any other possibility, but also I'm not sure how Gesture Handler may enter one of those two states. Either way, we decided to fix it in a different way (which hopefully will work). I created #3565 which should solve this problem. It would be great if you could test it, but I understand that it may be challenging. About this PR, please leave only the second fix, for |
Hi @billouboq! Just to let you know, I've merged #3565, so these changes are no longer necessary in this PR |
Thanks a lot for the changes ! 🙏 |
So are you willing to contribute to fix the other crash? 😅 If so, please leave only changes in |
Will do right now otherwise I know I will never take the time to do it 😁 |
9f0538f
to
538ced5
Compare
@m-bert Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! ❤️
Description
Without being able to reproduce, we saw some possible web crashed happening in react-native-gesture-handler.
So adding more guards to avoid that
Here are the sentry crashed :

