Skip to content

Error messages were removed from .title command #1946

@dgw

Description

@dgw

In #1510, the error feedback Sopel used to output if it couldn't find a title for one or more URL given to the .title command got removed. This is kind of regression-y, and was shipped already in 7.0.x before someone mentioned it. Here's how it looked:

sopel/sopel/modules/url.py

Lines 132 to 137 in 806f296

# Nice to have different failure messages for one-and-only requested URL
# failed vs. one-of-many failed.
if len(urls) == 1 and not results:
bot.reply('Sorry, fetching that title failed. Make sure the site is working.')
elif len(urls) > len(results):
bot.reply('I couldn\'t get all of the titles, but I fetched what I could!')
Might not be practical to do exactly the same thing now due to use of generators, but something similar would be enough.

Metadata

Metadata

Assignees

Labels

BugfixGenerally, PRs that reference (and fix) one or more issue(s)

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions