reddit: subreddit handling for r/all and r/popular #1763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
approved these changes
Feb 20, 2020
Contributor
Exirel
left a comment
Exirel
left a comment
There was a problem hiding this comment.
Just a nitpick, and nothing that prevent a merge.
deathbybandaid
force-pushed
the
reddit.update2
branch
from
6084278 to
b500eeb
Compare
Exirel
reviewed
Feb 20, 2020
deathbybandaid
force-pushed
the
reddit.update2
branch
from
b500eeb to
1e03e9f
Compare
Exirel
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per my comment in #1722 here's handling for the two non-subreddit subreddits!