Add flake8-import-order #1864
Merged
Add flake8-import-order #1864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
requested changes
May 19, 2020
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
All right, that wasn't too bad. Out of 108 files, I could check off 88 of them as ready-to-go. Only 20 files have changes I don't really like, and nearly all in one of these categories:
- Blank lines between third-party imports (why?)
- Sorting
from ... imports after plainimports (solution: usegooglestyle as I did in ab9762d)
Also in ab9762d, I configured the application namespace as sopel, which might affect some of this stuff. (I don't think there were any relative imports 1400 commits ago, so my branch doesn't have any changes with . to compare.)
9 tasks
dgw
approved these changes
May 19, 2020
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
Tweak the spaces in setup.cfg and we're good to squash. 👍
half-duplex
force-pushed
the
flake8-additions
branch
from
249b365 to
049d517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds flake8-import-order and fixes everything it complains about. See #1765
Checklist
make qa(runsmake qualityandmake test)